…you totally didn’t get the point I was trying to make. XD
i got it lol i just trying to point a whole new problem because ive read the github english trans
Hi, I’m part of the translation group and have been for the last couple weeks. For the most part, we need more native-Koreans to check lines deep within files. We don’t need perfect, perfect English -> understandable speech is preferable if we can get every line on that level, there are a lot of lines deep within files that are just plain gibberish.
If you’re new and want to actually help this game release faster, please try to refrain from starting at line 0 for basically any file, since I can assure you many others have gone through the first 200 lines of every file, as I have already for ETC and QUEST. Rule of thumb: if you can understand it and make sense of it, then it doesn’t need to be fixed (unless there’s a glaring typo, missing comma). There is little gain from shuffling words left and right on the first few lines over and over again.
You can translate things without having access to beta. Like everyone in this community who has translated, because nobody has accessed beta so far and have made great strides.
They’ve given THREE keys to people who committed more than 100 lines and that’s still not enough incentive to you? I don’t know if you meant to come off as entitled but…
@AmenoMiragu That recent shuffling might be due to people thinking if they try and commit some random things they’ll get keys…
Seeing as it’s a little to late now, I don’t see a point. If I knew about the translating for codes earlier I would’ve TOTALLLLYYY done that. I don’t mean to act “entitled”. I just didn’t have a clue about a reward like that.
I don’t think anyone did, you can tell by the responses in the announcement thread. Don’t you think a whole lot more people would’ve been involved if they felt like they’d get something out of it?
That’s exactly why it’s great they gave the keys out, people took time out of their lives to do things for the game and community instead of some “reward”.
Well, if you look at it being too late then go ahead and treat it that way. You can’t possibly expect anyone to give you a key because you said “i would translate if you gave me a key” lol. People are doing it without any incentive and…well, you see how that goes.
I’m not trying to be an ■■■■■■■ it just seems kind of ridiculous someone would say something like “I’d translate if I was given a key” considering there are lot of people doing it out of their own kindness already, lol. Then saying it’s too late so why bother…which only makes me think you don’t care about making things better/faster, but just that you can play the game or whatever.
1 Like
I enjoy grammar and language in general. It’s what I got my Master’s degree in. I get paid to do this kind of thing normally, but I’ve been bedridden for most of the last year. This is a great way for me to dust off my editing skills and get back into the swing of things. Plus, it really is fun, : ) just as you said.
1 Like
I’ve got a question… If I make a single change in a file, save that change and then create a pull request for this change, can I then go into my pull request and continue adding edits while the request is up?
Or would it be smarter to create a pull request for every batch of changes I make?
Perhabs it would even be better to create a pull request for every single little change I make…I’m really not sure about this
Great attitude! Glad people like you are part of the community!
The best suggestion is to make batches of changes in the 50-100 line range. If you don’t want to do 50 changes I would say about 20 is the minimum. Doing 1 change pull requests just clutter the pull requests a lot. There is currently 40 pending pull requests which is insane. Take a look at these guidelines:
Oh thanks a bunch.
Allright then, I’ll just review 100 lines at a time, create a pull request for that and add in the comments something along the lines of “Reviewed line 1-100 and corrected any mistakes I could find”
I think I’ll pass on that whole “marking the lines I’ve reviewed thing” for now since I’m not seeing any marks in the files right now, so I guess people haven’t decided on whether they wanna apply this rule or not
That’s still too vague for comments imo. It would be better if you say what file, what line-range, what exactly you did.
For example, I do things like "QUEST 1000 - 1132 revision1, spellcheck, added {nl}'s
Do you do that for every single line you review, or only for those where you actually edited something?
And what do these {nl}'s mean?
It might help translators to have that information readily available on the main page; IMC even stated that it wouldn’t be implemented until they had a clear set of guild lines to update with. I haven’t seen the tagging done on any of the files I’ve looked at, so are those new marking guidelines being used yet or not? Especially because the wiki currently says not to add any sort of extras to the coding.
Well, im from brasil, portuguese speaking, but i can help with translate. Besides, i saw a BR streamer and there was actually portuguese translated parts of the game… can we work on that too?
There’s is a brazilian team working on translations. Contact the Tree of savior Brasil page on facebook for more info
Guys, we click on pull requests from our fork page or from the oficial page to sent them requests?